Fix convert.fesom_to_ugrid dimension renaming#2579
Merged
VeckoTheGecko merged 4 commits intoParcels-code:mainfrom Apr 15, 2026
Merged
Fix convert.fesom_to_ugrid dimension renaming#2579VeckoTheGecko merged 4 commits intoParcels-code:mainfrom
VeckoTheGecko merged 4 commits intoParcels-code:mainfrom
Conversation
Lifting the pooch instance to the dataset definition allows us to be flexible to support different data sources in future
fluidnumericsJoe
approved these changes
Apr 14, 2026
Contributor
fluidnumericsJoe
left a comment
fluidnumericsJoe
left a comment
There was a problem hiding this comment.
No major comments. LGTM
erikvansebille
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfor normal development,v3-supportfor v3 support)